ltp
ltp copied to clipboard
Issue with testcases/kernel/fs/doio/rwtest
Hello,
https://github.com/linux-test-project/ltp/blob/51b89954e538f5299821432c879ff1e23c596ad8/testcases/kernel/fs/doio/rwtest#L332 This line of rwtest clears dir and dfOpts options if it is a symlink because a symlink to busybox does not take options as described in the comments. But we see cases with a symlink to df.coreutils which works well with options. I think more granular check is needed like
- if test -h $(which df)
- then
- dir=""; dfOpts="";
- fi
+ if [[ "$(readlink -f "$(which df)")" == *"busybox"* ]]
+ then
+ dir=""; dfOpts="";
+ fi
Thanks
Can you send a proper signed patch please?
https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/
Also note: https://github.com/linux-test-project/ltp/issues/1110