Cyril Hrubis
Cyril Hrubis
What exactly is the problem here? The change does not look good to me, as far as I understand the test we are trying to check if `pthread_kill()` will fail...
So this is same as #1067 and you are doing something very strange that static variables needs to be reinitialized this way. I do not understand why this is needed...
This is obviously correct, but I do get a few more errors when trying to compile the test. ``` ../../../stress/threads/sem_open/s-c1.c: In function ‘main’: ../../../stress/threads/sem_open/s-c1.c:114:14: warning: unused parameter ‘argc’ [-Wunused-parameter] 114...
The change does not look right, you are removing else branch that is supposedly not used at all. Is this really the change that fixes the tests for you?
What is the exact problem you are hitting? Is there something open with fd 274 before control is passed to `main()`?
Again the description should be rewritten, among other things it has to explain why the change is needed.
Looking at the test closely the point of the test is to figure out what happens when we attempt to lock an uninitialized lock and the end result is not...
Unfortunately we still have around 300 old testcases that have to be cleaned up and rewritten to use the new test library, we are down from more than 1000 when...
@dimakuv Let's keep it open, it increases the chance that someone will pick the task. Also as usual patches are welcome :-)
The actual commit hash is cf3128a7aca5. I suppose that we should drop the line since kernel started rejecting outbound policies, does the tests work with that particular line removed?