Mert Can Altin

Results 192 comments of Mert Can Altin

you need to edit your first commit message you can do it like this : ```doc: change ExperimentalWarnings to ExperimentalWarning```

https://github.com/nodejs/node/blob/021cf912084005f4ecd7db06e0bad75353067a46/test/parallel/test-whatwg-webstreams-compression.js#L1C2-L74C6 In addition, does it protect the current tests? @lpinca

> this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr? https://github.com/nodejs/node/pull/52283#issuecomment-2028462301 I wonder if this is true, I interpreted it as...

@rdw-msft https://ci.nodejs.org/job/node-test-pull-request/ You can find it by searching this address I tried to look for it but it seems to be lost I will look again during the day

> I seem to have botched something when syncing my fork and rebasing. I'm working on fixing this history. You can try to do your own code first by using...

From a developer point of view using ```-w``` can be positive, but as @tniessen said, I agree that long description is good for readability, I think we should evaluate this...

I added a test, so sorry for my delay ❤️

@MoLow @anonrig Do you think it would be good to fix these tests or should I focus on my code? [test/es-module/test-cjs-legacyMainResolve.js](https://github.com/nodejs/node/pull/51615/files#diff-0f5638d192db26449f57eb520f1ad73deb96f555b4b85a9fc1b60879678cdd1c) [test/es-module/test-cjs-esm-warn.js](https://github.com/nodejs/node/pull/51615/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547) [test/es-module/test-cjs-legacyMainResolve-permission.js](https://github.com/nodejs/node/pull/51615/files#diff-45fb5ae81829b42c1ade22215bf57f49254b52febe1f66852213461a424bfab8) [test/es-module/test-esm-cjs-builtins.js](https://github.com/nodejs/node/pull/51615/files#diff-66318ff7cc1968eb9341aeae63b67cf5b993cd7a31c155a4fa1a108ceff12d39) [test/es-module/test-esm-cjs-exports.js](https://github.com/nodejs/node/pull/51615/files#diff-9160259d79dd3b79202b5940dfc9eacef54aabb3388a39f4f7f1004d245b5fe6) [test/es-module/test-esm-cjs-main.js](https://github.com/nodejs/node/pull/51615/files#diff-3d3575fea36122ef2f9599322377ede3502ec2551bb60fdf7d580fa3bf98368e) [test/es-module/test-esm-encoded-path-native.js](https://github.com/nodejs/node/pull/51615/files#diff-1d1cab989f8a00837d829753336cc6c6c13cc0a2db226c97c39b441983c5ad9b) [test/es-module/test-esm-invalid-pjson.js](https://github.com/nodejs/node/pull/51615/files#diff-af415fd1b964ba5516cf56b3cc42381cfc2a14f65d7803f6c33e13dd02f57ee0) [test/es-module/test-esm-preserve-symlinks-main.js](https://github.com/nodejs/node/pull/51615/files#diff-ec16074a10df7a519529e0b09d6ed41f7c2dc2bbbd1a541252d0005b80e1ce21) [test/es-module/test-esm-repl-imports.js](https://github.com/nodejs/node/pull/51615/files#diff-64d61e3f2be769df6abde84e8528c5abaffc80425407eab5ddb0e7a10aca08ec)...

instead of the old solution I made a normalizeFilePath method and replaced the path with file if `process.platform === 'win32'` @mcollina Is it healthy to control win32 ?

When I look before the test, I get the output of x509.extensions undefined. Could it be because I cannot access it because it is undefined?