node icon indicating copy to clipboard operation
node copied to clipboard

streams: fix util inspect returning undefined for CompressionStream & DecompressionStream

Open mertcanaltin opened this issue 2 months ago • 7 comments

The customInspect method within the internal module node/lib/internal/webstreams/compression.js was missing a return statement, causing util.inspect to return undefined when inspecting instances of CompressionStream and DecompressionStream. This commit adds the missing return statement to ensure that util.inspect displays the correct information for these stream instances. https://github.com/nodejs/node/issues/52263

mertcanaltin avatar Mar 30 '24 20:03 mertcanaltin

https://github.com/nodejs/node/blob/021cf912084005f4ecd7db06e0bad75353067a46/test/parallel/test-whatwg-webstreams-compression.js#L1C2-L74C6 In addition, does it protect the current tests? @lpinca

mertcanaltin avatar Mar 30 '24 20:03 mertcanaltin

CI: https://ci.nodejs.org/job/node-test-pull-request/58140/

nodejs-github-bot avatar Apr 05 '24 13:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58165/

nodejs-github-bot avatar Apr 06 '24 22:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58210/

nodejs-github-bot avatar Apr 08 '24 13:04 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/58766/

nodejs-github-bot avatar Apr 28 '24 02:04 nodejs-github-bot

this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr?

MoLow avatar Apr 28 '24 05:04 MoLow

this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr?

https://github.com/nodejs/node/pull/52283#issuecomment-2028462301

I wonder if this is true, I interpreted it as no need for a test @MoLow

mertcanaltin avatar Apr 28 '24 07:04 mertcanaltin

@mertcanaltin adding a test is always good to prevent regressions. So far this is clearly not covered, otherwise it would have been detected :)

BridgeAR avatar May 04 '24 11:05 BridgeAR

CI: https://ci.nodejs.org/job/node-test-pull-request/58918/

nodejs-github-bot avatar May 04 '24 11:05 nodejs-github-bot