node
node copied to clipboard
nodejs
streams: fix util inspect returning undefined for CompressionStream & DecompressionStream
The customInspect method within the internal module node/lib/internal/webstreams/compression.js was missing a return statement, causing util.inspect to return undefined when inspecting instances of CompressionStream and DecompressionStream. This commit adds the missing return statement to ensure that util.inspect displays the correct information for these stream instances. https://github.com/nodejs/node/issues/52263
https://github.com/nodejs/node/blob/021cf912084005f4ecd7db06e0bad75353067a46/test/parallel/test-whatwg-webstreams-compression.js#L1C2-L74C6 In addition, does it protect the current tests? @lpinca
this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr?
this PR seems to be missing a test. @mertcanaltin can you please add on in a follow-up pr?
https://github.com/nodejs/node/pull/52283#issuecomment-2028462301
I wonder if this is true, I interpreted it as no need for a test @MoLow
@mertcanaltin adding a test is always good to prevent regressions. So far this is clearly not covered, otherwise it would have been detected :)
