Ed Merks

Results 491 comments of Ed Merks

It's quite a basic implementation using the browser: https://github.com/eclipse-oomph/oomph/blob/a4fd02c80a50c0312e2ac26559a32c25de978d38/plugins/org.eclipse.oomph.setup.editor/src/org/eclipse/oomph/setup/presentation/NotificationViewPart.java#L172-L215 Eventually it sets a URL: https://github.com/eclipse-oomph/oomph/blob/a4fd02c80a50c0312e2ac26559a32c25de978d38/plugins/org.eclipse.oomph.setup.editor/src/org/eclipse/oomph/setup/presentation/NotificationViewPart.java#L168

Given @akurtakov is doing lots of GTK4 work it would be in everyone's best interest to use the very latest Eclipse. Given you get this notification you are **definitely not**...

FYI, here is an example of the URL is would open (with URL query parameters depending the host IDE): https://www.eclipse.org/setups/notification/milestone/?product-id=org.eclipse.epp.package.committers.product&product-name=Eclipse%20IDE&application-id=org.eclipse.ui.ide.workbench&bundle-id=org.eclipse.epp.package.committers&bundle-version=4.37.0.20250821-0636&java.vendor=Eclipse%20Adoptium&java.version=21.0.4&color=%23000000ff&background-color=%23f8f8f8ff

Be careful here. It's already the case that if one uses the branding iron, the native window executables in the p2 repository, "hidden" binary files, are not signed and an...

I would love it to be less complicated! But as long as the Platform doesn't have the problem it's probably not going to get less complicated. And the problem is...

If you want to brand with an icon (like the installer does) you'd have to do what's described here: https://tycho.eclipseprojects.io/doc/main/SignProducts.html Or you will have the problem described here: https://github.com/eclipse-tycho/tycho/issues/2510

Is there something off about the about the content of this file, i.e., the `.project` file located at `file:/C:/Users/jkubitz/platform-2024-09-23/git/eclipse.platform.ui/releng/org.eclipse.ui.releng`: ![image](https://github.com/user-attachments/assets/4f7bb53c-5166-434c-bbc0-b6fdb6730cf9) ![image](https://github.com/user-attachments/assets/27874584-f5a7-4d42-b300-36bc826c96a6) This works fine for me and as you can...

That leaves the workspace in kind of an inconsistent state. I suppose if you delete the project (without deleting it on disk), it will be imported with the correct name...

Yes, it's kind of confusing when the folder and IProject names are different...

Yes, this is referenced via absolute URI from another setup, i.e., this one. So if the path were to be changed, the URI would need to be changed here: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/420650837e7249e2a58714554f074f22ff4be764/oomph/Platform.setup#L922