Ed Merks

Results 491 comments of Ed Merks

It seems to me that no method of org.eclipse.ui.internal.WorkbenchPage is thread safe such that one can call it from a background thread. I see nothing to suggest there is any...

a) Changing the underlying model implementation, i.e., org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.findElementsRecursive, that paws through a tree of data structures all of which are implemented via an EMF model is pretty much a non-starter...

I wonder if this really the correct fix. Isn't it possible for a product to override defaults? Should it maybe be like this? ``` int markerLimits = preferenceStore.getInt(IDEInternalPreferences.MARKER_LIMITS_VALUE); ``` Indeed,...

Are you referring the "Show Revision" decorations in an editor or the Blame view on GitHub web page, or just to the button to ignore white space change when comparing...

I've seen problems like this with the automatic refresh in other contexts. It's really nice that the IDE refreshes automatically, unfortunately it will also do that automatically sometimes in the...

@speckyspooky @wimjongman I'd like to do a first milestone build so that the generated Oomph products show a release choice as well as two choices for 4.18 versions: ![image](https://github.com/user-attachments/assets/c6e9755c-965b-4d39-bb6f-70ec62aae287) ![image](https://github.com/user-attachments/assets/4bf71b74-58d8-4d46-b377-4cbfeabf6e88)...

This looks fine for me too: ![image](https://github.com/user-attachments/assets/289904ab-9bc7-4674-a408-4ea574f27c62) And it should be fine because the re-export from core should properly make things visible. Perhaps a PDE glitching with the target platform...

@hvbtup Can I delete this branch now? I think it's been merged, right? https://github.com/eclipse-birt/birt/tree/tagged-pdf