#2323 'Restore Defaults' uses different value when USE_MARKER_LIMITS pref is false.

[eobrienPilz]

Proposed fix for issue #2323 is to use 100 as the default value on first launch and also on pressing the 'Restore Defaults' button.

[github-actions[bot]]

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 31m 21s ⏱️ +13s  7 734 tests ±0   7 506 ✅ ±0  228 💤 ±0  0 ❌ ±0  24 363 runs  ±0  23 614 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 68b5f2b2. ± Comparison against base commit d8afbe0b.

:recycle: This comment has been updated with latest results.

[eobrienPilz]

Is anyone available to review this ? Its just a small fix and shouldn't have any side effects.

[merks]

I wonder if this really the correct fix. Isn't it possible for a product to override defaults?

Should it maybe be like this?

int markerLimits = preferenceStore.getInt(IDEInternalPreferences.MARKER_LIMITS_VALUE);

Indeed, this looks like an example of such customization:

[eobrienPilz]

Yes, I am not sure if there is a reason why pressing restore defaults uses a hard coded value. I'll see if I can change it so that it always uses the stored default like you suggest.

[merks]

Yes, the 1000 is definitely fishy. 😕

[eobrienPilz]

I made the update and tested it. The restore defaults button now sets the the stored preference value, as expected.

[merks]

🙏