Matt Epland
Matt Epland
@parrt @tlapusan I don't think this issue pertains to `spark`, as `Rectangle` is a matplotlib class. Something may have been wrong with @sergiocalde94 's installation / packages? This error isn't...
@parrt I think this issue can be closed.
@parrt we could try moving the wedge down, but we'd also need to move the feature name / x-axis label.
@parrt Hmm that just turns the wedge off, not an ideal solution. I think we should give the user options: 1. The current behavior, you may have overlaps. 2. Hide...
> I wonder what we do for regression. I think I simply move to the label away from the wedge. Ah: > > ``` > if node.split() > xmin +...
> 1. It definitely makes sense to combine that functionality to generate a wedge. Sounds good, will do. > 2. What if we moved the wedges below the axis but...
@parrt actually, looking at the wedge plotting code, only classification tree non-categorical splits get a text label under the wedge. I've started refactoring the wedge plotting code in https://github.com/parrt/dtreeviz/pull/236 [here](https://github.com/parrt/dtreeviz/pull/236/commits/65f7e319f4631c22e29c9c85240e35ceae9c7073),...
@parrt I think that is a tick label, not an extra text object like is done for the classification trees: ``` ax.text(tip_x, tip_y -2 * tri_height, f"{myround(x, precision)}", horizontalalignment='center', fontsize=ticks_fontsize,...
@parrt see my comments on #236
Resolved by https://github.com/parrt/dtreeviz/pull/236