mental

Results 22 comments of mental

Actually I wouldn't recommend that @frafra `spotify.Client` is made to me created once and carried around for the lifetime of the program. So creating and destroying instances on every route...

@frafra It was my intention that the codeblock I posted be combined with your one haha would anyone like to PR this in themselves? Don't worry if not, I can...

@josephlr (friendly ping :D) do you have any comments?

I opened a somewhat related PR #224 that let's *Range types be constructed from `Range`. I'll check out the `step_trait` branch and see if I can figure out the trait...

> Can we add some sort of in-flight request count limiting? Unless it is intended for the users to implement this on their own using something like a semaphore. not...

uh sure normally I'd say that'd be something for the user but since we're the ones using this it makes sense :smile: ```rs pub struct RateLimitedTMDBMetadataProviderRef { ... } ```...

One thing to note here for this PR the main thing missing for this impl is a way to handle errors from the underlying in-flight request. The current impl will...

> > One thing to note here for this PR the main thing missing for this impl is a way to handle errors from the underlying in-flight request. The current...

> 1. ffmpeg path are hardcoded (and non system standard) in dim/src/streaming/mod.rs it's not designed to be system standard, we're planning on building and shipping ffmpeg releases with extra stuff...

FWIW, with this it'd be cool to have a button to a library's drop-down menu to trigger a re-scan