x86_64 icon indicating copy to clipboard operation
x86_64 copied to clipboard

Add a `Mapper::map` convenience method

Open phil-opp opened this issue 5 years ago • 6 comments

Instead of requiring the caller to specify the target frame, this method uses a frame allocated from the frame allocator. This makes the common use case of mapping a page to an unused physical frame more convenient.

Builds upon #135, so there are some additional commits in this PR. I will rebase it as soon as #135 is merged.

phil-opp avatar Mar 06 '20 14:03 phil-opp

@phil-opp this looks reasonable to me. If you rebase, I can review.

josephlr avatar Oct 16 '20 10:10 josephlr

Rebased

phil-opp avatar Oct 18 '20 09:10 phil-opp

@josephlr (friendly ping :D) do you have any comments?

mental32 avatar Dec 28 '20 17:12 mental32

@phil-opp sorry for missing this, will review this, #266, and #264 to figure out which mapping improvements we want.

josephlr avatar Jul 17 '21 01:07 josephlr

@josephlr Thanks a lot! The past weeks have been busy for me, so I haven't had time to review these PRs yet. Feel free to ping me if you need any input from me.

phil-opp avatar Jul 17 '21 15:07 phil-opp

@josephlr Do you have time for a quick review?

phil-opp avatar Sep 04 '21 13:09 phil-opp