Mathis Engelbart

Results 9 comments of Mathis Engelbart

@adriancable I understand the wish to have an agreement as a community on what compilers Pion supports and I think that what @jech described above worked well in the past....

Congestion Control currently does not work with RFC 8888. We have https://github.com/pion/interceptor/pull/112 for adding an RFC 8888 interceptor to generate feedback, but that currently does not perform as good as...

I think there's a little inconsistency between the `TransportLayerCC` (and in master also the `CCFeedbackReport` from RFC8888) and the other packets. While most of the packets have a `Header()` method...

Technically I agree with @aler9 because it is what all the other packet types implement, too. But unfortunately, this is a breaking change. See also [this comment](https://github.com/pion/rtcp/issues/127#issuecomment-1104205368). I would like...

> Yes, although since it's only a few bytes I figured I'd do it in a followup PR sweat_smile Alright, follow up PR sounds fine to me :) > The...

@kevmo314 This is great, thanks for implementing it! Sorry I didn't get to review/test this earlier! I started #149 now to integrate it into interceptors and will try to find...

Hi @kevmo314 sorry I didn't reply to this earlier. I don't think we should add the loss rate to the `BandwidthEstimator` interface, because it is not clear if all implementations...

Mh, interesting, no idea if that will be helpful for you then. Anyway, I think the GCC interceptor allows you to get `averageLoss` via the `GetStats`, too, but I think...

Draft because we might want to add a test case. And I don't know what's wrong with that failing test...