interceptor icon indicating copy to clipboard operation
interceptor copied to clipboard

Add NADA implementation

Open kevmo314 opened this issue 2 years ago • 2 comments

This change adds the NADA congestion control implementation. The binding to cc is left TODO.

kevmo314 avatar Apr 02 '22 19:04 kevmo314

Codecov Report

Merging #117 (48779ed) into master (09051cd) will decrease coverage by 0.01%. The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   79.30%   79.29%   -0.02%     
==========================================
  Files          51       56       +5     
  Lines        2460     2748     +288     
==========================================
+ Hits         1951     2179     +228     
- Misses        419      470      +51     
- Partials       90       99       +9     
Flag Coverage Δ
go 79.29% <79.16%> (-0.02%) :arrow_down:
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
interceptor.go 100.00% <ø> (ø)
pkg/nack/retainable_packet.go 86.76% <ø> (ø)
pkg/nada/report.go 0.00% <0.00%> (ø)
pkg/nada/packet_stream.go 65.75% <65.75%> (ø)
pkg/nada/receiver.go 93.67% <93.67%> (ø)
pkg/nada/sender.go 93.75% <93.75%> (ø)
pkg/nada/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09051cd...48779ed. Read the comment docs.

codecov[bot] avatar Apr 02 '22 19:04 codecov[bot]

@kevmo314 This is great, thanks for implementing it! Sorry I didn't get to review/test this earlier! I started #149 now to integrate it into interceptors and will try to find some time to review the code and understand NADA better.

mengelbart avatar Jul 23 '22 22:07 mengelbart