Michael Ellery

I very much like and need this specific functionality, but I can understand wanting to keep the core clean. If anything, maybe we can come up with a plan to...

I think the cmake files have diverged a bit and this PR would need to be rebased/updated if it were to get merged. That said, there are a few questionable...

sounds good - I'll see if I can formulate a patch that creates the "extras" target for cmake users.

@courteous that README probably never got updated after some changes to the cmake. The [travis-ci script](https://github.com/HowardHinnant/date/blob/master/.travis.yml#L142-L146) is a good indication of what you want to do, although what you've written...

[BUILD_SHARED_LIBS](https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html) is a general CMake option that just determines the type of library that `add_library` will produce (if not explicitly specified). Prior to the commit you reference, the `tz`library was...

I haven't followed, but aren't we just talking about https://github.com/HowardHinnant/date/blob/9a0ee2542848ab8625984fc8cdbfb9b5414c0082/src/tz.cpp#L226-L232 ? If there is something the build system can do to override or make this more configurable by packages/installers, I'm...

you need to add `-DENABLE_DATE_TESTING=ON` when configuring...test targets are disabled by default.

the `build.make` file you are looking for would be in `/home/mmorsi/Workspace/rippled/.nih_c/unix_makefiles/GNU_9.2.1/Release/src/grpc_src-build/CMakeFiles/gen_percent_encoding_tables.dir`. That said, this is part of the gRPC build and I don't see any similar issues reported in their...

I mistyped that path above - sorry. It should be `/home/mmorsi/Workspace/rippled/.nih_c/unix_makefiles/GNU_9.2.1/Release/src/grpc_src-build/CMakeFiles` (also edited above). I use ubuntu 18.04 for development. Your toolchain is quite modern and protobuf 3.6 should be...

this is good info - grpc is not finding protobuf. Let me dig a little more in their build files and get back to you...