date icon indicating copy to clipboard operation
date copied to clipboard

Documentation cmake default command

Open courteous opened this issue 4 years ago • 2 comments

Hello Howard,

first thank you for this beautiful library. I have only one simple question. I have tried to build the library as mentioned in the section Build & Test with debian / gcc 9.3.0. i.e.

cmake ../ cmake --build . --target testit

this does not do anything

should that not be changed to something like:

cmake -DBUILD_SHARED_LIBS=ON requires -DBUILD_TZ_LIB=ON ../ make -j8

that produces a file called libdate-tz.so ? It took me some time to find the correct options to compile with, maybe we can avoid that in the future. Or am i missing something here?

thank you for your time!

courteous avatar Jul 23 '20 18:07 courteous

Hi courteous,

Thank you for your comments.

I personally loathe cmake and don't use it. For me it causes way more problems than it solves.

I use the instructions here: https://howardhinnant.github.io/date/tz.html#Installation

I would be happy to accept a PR from you that updated the readme. And then I should probably follow up with a link to the instructions I use.

HowardHinnant avatar Jul 23 '20 18:07 HowardHinnant

@courteous that README probably never got updated after some changes to the cmake. The travis-ci script is a good indication of what you want to do, although what you've written above works fine as well.

mellery451 avatar Jul 23 '20 18:07 mellery451