container - add hugepages config

[DrFaust92]

Closes https://github.com/hashicorp/terraform-provider-google/issues/16497

tested locally:

--- PASS: TestAccContainerNodePool_withHugepageConfig (817.36s)

Release Note Template for Downstream PRs (will be copied)

container: add `hugepages_config` in `linux_node_config` in `google_container_node_pool` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions[bot]]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

Apologies for the delayed review - reassigning since I'll be OOO tomorrow.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 143 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 143 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (387 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

Resource: google_container_node_pool (74 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 205 Passed tests: 191 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccContainerNodePool_withHugepageConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[github-actions[bot]]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[DrFaust92]

thanks slevenick, added + covered second param in that block as well

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 144 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 144 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (387 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 205 Passed tests: 191 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccContainerNodePool_withHugepageConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[DrFaust92]

thanks slevenick, fixed + tested properly

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 145 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (394 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      hugepages_config {
        hugepage_size_1g = # value needed
        hugepage_size_2m = # value needed
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        hugepages_config {
          hugepage_size_1g = # value needed
          hugepage_size_2m = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 211 Passed tests: 197 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_withHugepageConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccContainerNodePool_withHugepageConfig[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test