Jonas

Results 475 comments of Jonas

Closing as duplicate of #1249 (because that issue has more discussion).

The cypress tests need to be fixed first, I think @Hephi2 will do so later.

> It is most of the time faster to compile and commit it locally :) Thanks @susnux! But for the sake of easier backports its still better to keep source...

I don't understand why the Cypress Tests fail here :thinking:

I splitted the PR between source code changes and compiled JS assets and rebased. Cypress CI test issues seem to have solved themselves :magic_wand:

Given that there's no further communication here and I agree that this feature probably will not go into the server as is, let's close the issue.

Dear @serebrov, thanks for your feedback. first, I completely agree that this should be an optional feature, to be enabled with a property and off per default. > Probably, the...

Hey @serebrov, sorry for not getting back to you earlier. I forgot a bit to answer here :see_no_evil: So maybe with the following screenshots you get a better understanding: the...

First, thanks a lot @serebrov for picking up this issue :heart: Also, thanks @jancborchardt, I think I like your approach. What do you think about it @serebrov?

For us this issue is solved with the [suggested solution](https://github.com/serebrov/emoji-mart-vue/issues/253#issuecomment-1585978632) by @serebrov. See https://github.com/nextcloud-libraries/nextcloud-vue/pull/4381/files#diff-d7f3b7d9ce2fc5c58387de5832a3ab1720a143d1032e1ed2134927a6491b6e6dR163-R179 for the code how we implemented the unselect option in Nextclouds `NcEmojiPicker` component.