Jonas

Results 375 comments of Jonas

Thanks a lot for looking into this @vinicius73 :heart: Unfortunately using the menubar space in read-only mode conflicts with Collectives, where we already use this space for Collectives-specific content (last...

> What do you think about make able to inject a slot that space and expose some editor methods? > > So that way you will be able to not...

@vinicius73 could you take a quick look into rebasing the PR on latest master? Seems like something went wrong and unrelated commits got pulled in :wink:

Nice, thanks a lot @vinicius73. Works like expected. I removed the `top: 104px` as discussed [here](https://github.com/nextcloud/text/issues/2904#issuecomment-1247244100). It doesn't solve the problem for Collectives yet, but at least it doesn't break...

/backport 103d8ef26df9ec6c86098eecbf16304f08248f7d,7d9a18b15c56608fa38492ec9d7f877130922488 to stable25

The reason is that we intentionally [set `inline: true` for image nodes](https://github.com/nextcloud/text/blob/b901530e68e32756faabde9e2b3d0dc30823d9f4/src/extensions/RichText.js#L86). Not sure whether that's a good thing though, given that images (and attachments) are complex structures with nested...

> As we are using complex render strategies to render attachments, it can't be handled inline mode. I agree. I wonder though, what implications switching from inline to block mode...

/backport 9d053cf205fedbe7d23b4e6ddacfc985411cf6bf to stable25