server icon indicating copy to clipboard operation
server copied to clipboard

fix(core): Do not invert app menu text color

Open Hephi2 opened this issue 2 years ago • 10 comments

  • Resolves: #38759 Fixes #38759

Summary

Instead of inverting the color of the whole app entry in the menubar when using a light background, only the color of the app icon is inverted. The invertion of the label color already happens here: https://github.com/nextcloud/server/blob/63bf207ca7a18dd50ce3aeaea42e53f4ee400fc0/apps/theming/lib/Themes/CommonThemeTrait.php#L68

##Screenshots Before: image

After: image

Tested on Chrome, Edge, Firefox and Opera Browser

Hephi2 avatar Jun 12 '23 16:06 Hephi2

Conflicts...

szaimen avatar Jun 12 '23 16:06 szaimen

/compile /

szaimen avatar Jun 13 '23 13:06 szaimen

The cypress tests need to be fixed first, I think @Hephi2 will do so later.

mejo- avatar Jun 13 '23 14:06 mejo-

/compile

Hephi2 avatar Jun 14 '23 11:06 Hephi2

/compile

Hephi2 avatar Jun 14 '23 13:06 Hephi2

/compile

It is most of the time faster to compile and commit it locally :)

susnux avatar Jun 14 '23 15:06 susnux

It is most of the time faster to compile and commit it locally :)

Thanks @susnux! But for the sake of easier backports its still better to keep source changes and compiled asset changes in separate commits, no?

mejo- avatar Jun 14 '23 15:06 mejo-

I don't understand why the Cypress Tests fail here :thinking:

mejo- avatar Jun 14 '23 20:06 mejo-

Restarted.

juliusknorr avatar Jun 15 '23 07:06 juliusknorr

Locally it works. Cypress seems currently broken on CI (server master) (see all other CI runs)

susnux avatar Jun 15 '23 14:06 susnux

I splitted the PR between source code changes and compiled JS assets and rebased. Cypress CI test issues seem to have solved themselves :magic_wand:

mejo- avatar Jun 19 '23 07:06 mejo-

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

welcome[bot] avatar Jun 19 '23 09:06 welcome[bot]

/backport 7f861980a3b9d07076b89bbb9311f9bab00a935f to stable27

Hephi2 avatar Jun 19 '23 10:06 Hephi2

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport