Melissa Bristow

Results 10 comments of Melissa Bristow

> > LGTM, but some tests are failing. > > Also, @Shruthi42 is probably a much more appropriate reviewer than I am for this PR. Good to know, thanks!

> Looking good! I added suggestions for corner cases. Also, you had another safety check in the runner, to only call the function when we are really doing multi-node? Should...

> Do you know why the `test-artifact-pkg` test is failing? Could [this](https://github.com/pypa/gh-action-pypi-publish/discussions/49) be the answer - that a workflow triggered by a PR event cannot access secrets because the PR...

> I guess, although I can't see in the [workflow](https://github.com/microsoft/hi-ml/actions/runs/2733828639/workflow) where that job uses a secret. Maybe I'm missing something. What do you mean by "pushing the change"? What do...

> > It uses secrets including the Workspace details (that we would otherwise store in a config.json file) > > The workflow does, but not that specific step, I think....

Why not straight to version 3.10?

This is great, thanks! Re the samples files not being in any toctree, yes this is expected. These files are linked to in other areas of the docs (mostly in...

> I wonder why Dependabot is trying to upgrade NumPy. I thought the settings are only for GitHub actions... Dependabot tries to help us keep all dependencies up to date...

Not really ready for review, but can't see whether merging would be blocked until the PR is marked as ready

This is because the file 'docs/source/multimodal.md' is symlinked, and AML (v2) evaluates the symlink and then tries to find that relative path