hi-ml icon indicating copy to clipboard operation
hi-ml copied to clipboard

Bump pypa/gh-action-pypi-publish from 1.5.0 to 1.5.1

Open dependabot[bot] opened this issue 3 years ago • 7 comments

Bumps pypa/gh-action-pypi-publish from 1.5.0 to 1.5.1.

Release notes

Sourced from pypa/gh-action-pypi-publish's releases.

v1.5.1

What's Changed

Full Changelog: https://github.com/pypa/gh-action-pypi-publish/compare/v1.5.0...v1.5.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Jul 25 '22 16:07 dependabot[bot]

Codecov Report

Merging #534 (1d052d1) into main (5152021) will increase coverage by 8.80%. The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
hi-ml-azure 72.21% <ø> (+46.57%) :arrow_up:
hi-ml-cpath 77.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/datasets.py 40.13% <0.00%> (+23.80%) :arrow_up:
hi-ml-azure/src/health_azure/himl.py 97.91% <0.00%> (+40.10%) :arrow_up:
hi-ml-azure/src/health_azure/utils.py 72.79% <0.00%> (+46.63%) :arrow_up:
hi-ml-azure/src/health_azure/himl_download.py 55.55% <0.00%> (+55.55%) :arrow_up:
hi-ml-azure/src/health_azure/traverse.py 88.18% <0.00%> (+74.80%) :arrow_up:
hi-ml-azure/src/health_azure/paths.py 83.33% <0.00%> (+83.33%) :arrow_up:
hi-ml-azure/src/health_azure/himl_tensorboard.py 89.28% <0.00%> (+89.28%) :arrow_up:

codecov[bot] avatar Jul 25 '22 16:07 codecov[bot]

Do you know why the test-artifact-pkg test is failing?

fepegar avatar Aug 03 '22 08:08 fepegar

Do you know why the test-artifact-pkg test is failing?

Could this be the answer - that a workflow triggered by a PR event cannot access secrets because the PR may have been submitted by a malicious user? This answer suggests to try pushing the change instead

mebristo avatar Aug 03 '22 08:08 mebristo

I guess, although I can't see in the workflow where that job uses a secret. Maybe I'm missing something. What do you mean by "pushing the change"? What do you suggest we do?

fepegar avatar Aug 03 '22 09:08 fepegar

I guess, although I can't see in the workflow where that job uses a secret. Maybe I'm missing something. What do you mean by "pushing the change"? What do you suggest we do?

It uses secrets including the Workspace details (that we would otherwise store in a config.json file). We could try pushing a minor change to this PR and see if the workflow that gets triggered now passes, as a quick fix. This is a known problem though and there are some more involved answers here such as separating the workflow into two workflows, with one being a separate workflow purely for the dependabot bot that runs on workflow_run and can access the secrets

mebristo avatar Aug 03 '22 09:08 mebristo

It uses secrets including the Workspace details (that we would otherwise store in a config.json file)

The workflow does, but not that specific step, I think. Many other CI checks that use secrets are passing, though. Why not this one in particular?

We could try pushing a minor change to this PR and see if the workflow that gets triggered now passes

Note you can use an empty commit for that. E.g.,

git commit --allow-empty -m "Trigger CI"

fepegar avatar Aug 03 '22 10:08 fepegar

It uses secrets including the Workspace details (that we would otherwise store in a config.json file)

The workflow does, but not that specific step, I think. Many other CI checks that use secrets are passing, though. Why not this one in particular?

We could try pushing a minor change to this PR and see if the workflow that gets triggered now passes

Note you can use an empty commit for that. E.g.,

git commit --allow-empty -m "Trigger CI"

The steps that I see failing are testazure tests that require a Workflow object

mebristo avatar Aug 03 '22 10:08 mebristo

superseded by #589

ant0nsc avatar Sep 02 '22 15:09 ant0nsc

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Sep 02 '22 15:09 dependabot[bot]