Matt Solomon
Matt Solomon
When I try sending a transaction on this chain I get a JSON RPC error: `TransactionsController: Can only call updateEditableParams on an unapproved transaction`. I have not seen this before,...
Closing as stale
Hmm, I'm hesitant about overcomplicating this flag—if you change the number of fuzz runs by changing your profile, you can also update the max number of rejects in that profile...
Yes definitely! So I recall last time we chatted about this a tricky part was that the upgrade transactions are executed in this repo, but our test suite is in...
For performance reasons I would suggest only running the monorepo tests in CI on some schedule (e.g. every 4 hours) to avoid having to wait multiple minutes to simulate and...
Hey! Yes that's close. So you'll see the `script/utils/check-task-statuses.sh` already loops through all tasks to check their status. We can modify that file (and rename it accordingly, to also simulate)....
Thank you! > Am I correct in thinking that ./SINGLE.md and ./NESTED.md contain direct, universal guidelines for single and nested tasks, respectively? Should all subsequent tasks be simulated based on...
Comment from @maurelian: > Do we have plans to run them sequentially in the same forked EVM state to avoid nonce issues? This is a good idea, since some tasks...
Hmm, what's the rationale for it? I would lean towards keeping constants in `CommonBase` to avoid over-abstracting things. Currently all `Std*` contracts are independent of `CommonBase`, so this suggestion would...
I do like the idea of having them as free constants. The main blocker there is forge-std currently supports as early as solidity 0.6.2, but I believe free functions (and...