Matt Solomon comments

Results 519 comments of


                                            Matt Solomon

Test function early returns after `vm.expectRevert`

Thanks for testing! So IMO this is a bug that we should fix, cc @mattsse. According to the [docs](https://book.getfoundry.sh/cheatcodes/expect-revert#expectrevert), `expectRevert` looks for a revert in the next call. In that...

Test function early returns after `vm.expectRevert`

In addition to the issue @frangio described, the other big issue which is what the issue title is about is this: ```solidity contract ContractTest is Test { function reverts(bool b)...

feat: test for reentrancy in invariant tests

There's a simple version of reentrancy invariant testing that @joshieDo added and is currently off by default, but the approach isn't perfect (not sure any approach will be though). IMO...

feat: test for reentrancy in invariant tests

From a quick read of that repo it seems it manually sets up a handler for reentrancy testing. If that's the approach we want to recommend (since I don't think...

feat: add a log helper library to easily log entire structs directly

This is interesting, and I like the idea. My main objection with adding this as-is to forge-std is it's impact on compile time. With via-ir, this library takes ~3s to...

feat: add a log helper library to easily log entire structs directly

Closing, and created https://github.com/foundry-rs/foundry/issues/7773 to track

writeJson for Array of Objects

cc @odyslam

writeJson for Array of Objects

Also should we transfer this issue to the main foundry repo? cc @mattsse

feat(cast): add `cast events <txHash>` to fetch and format events from receipt

Just noting this is similar to [`seth events`](https://github.com/dapphub/dapptools/blob/master/src/seth/libexec/seth/seth-events), though that requires specifying an address, and optionally a block or `--follow` mode, instead of a transaction hash. I think supporting all...

feat(cast): add `cast events <txHash>` to fetch and format events from receipt

That seems good to me! > I also would find it useful to be able to get all events that match a boolean expression in a block range @tynes Do...