Mark Nelson
Mark Nelson
Hi, There are a few things that need addressed. 1. The complaints from the GitHub Actions report. 2. I support Moodle 4.1 upwards so we should be using type hints,...
Thanks @michallohnisky. Are you able to add some unit tests to this as well? Take a look at https://github.com/mdjnelson/moodle-mod_customcert/blob/MOODLE_404_STABLE/tests/external_test.php to see other examples. :)
Regarding the points - 2. These web services were created ages ago before type hinting and return types were a thing in PHP. 4. The SQL indentation was corrected so...
You can run the unit tests locally before pushing them. :) https://docs.moodle.org/dev/Writing_PHPUnit_tests
I run the unit tests on my machine and I do not use Docker for Moodle development as I find the Moodle HQ container to be extremely slow. So, its...
This is a good PR, and adds good functionality. I am going to take a look at it now. Sorry for the delay.
Included this change and made some adjustments. Thanks!
Do you have `mod_certificate` installed? What does the URL look like?
Seems like a bug in Moodle that is still loading the URLs from plugins even though they are disabled. I would file a bug at tracker.moodle.org with instructions on how...
Hi @duranchen. I think this is a bug in Moodle and an issue should be made at tracker.moodle.org with details on how to replicate this - basically install this plugin,...