Mark Nelson
Mark Nelson
I looked into this more and think I know what is going on. Will work on a fix now if I get to that stage.
I pushed a fix for this. Closing.
Hi @ojnadjarm, thanks for this. Have you seen the comments I left on Mohamed's PR at https://github.com/mdjnelson/moodle-mod_customcert/pull/610? There are a few things I would like addressed. Also please prepend #531...
Are you able to rebase these changes on the latest `MOODLE_404_STABLE` branch please? This branch contains the changes #610 introduced as well as some minor tweaks by myself.
Pinging @ojnadjarm. I'd really like to get this in before I do my next release so are you able to do that rebase for me? :)
> Hi @mdjnelson, I wasn't using the table, so my PR modified the install.xml and the install.php was deleted. I'm not sure, if you are ok with that. Review the...
Thanks @ojnadjarm. Ill look at this on the weekend.
Ive included this in my recent updates, thanks!
Can you please look at failing CI pipeline please?
Please rebase on the latest MOODLE_404_STABLE branch as I have bumped the Moodle Plugin CI version.