Mark Nelson

Results 328 comments of Mark Nelson

The plugin contains no logic involving the conditions required to access an activity. This is a feature available to all activities via the Moodle API. I guess one solution to...

Ah, I see. We have https://github.com/mdjnelson/moodle-mod_customcert/blob/MOODLE_404_STABLE/view.php#L196 which marks the certificate as viewed which ensures the completion status is set. Perhaps this needs to be done when it is emailed as...

I would have to add more logic to the plugin in order to have another field, which means more things I need to maintain. That current condition in the certificate...

A new setting was added recently that allows you to change the format of how the code is generated, see https://github.com/mdjnelson/moodle-mod_customcert/issues/668.

This is on my list to look at next. The code looks good from a quick glance, sorry for the delay. Are you able to do a rebase on the...

Actually, don't worry about it ill resolve them myself. Ill look at putting this in 4.4 first then backporting from there, thanks.

Pushed up the code in 4.4, will see how GHA behaves and backport. Made a few minor adjustments and did some refactoring. Thanks for your hard work, much appreciated.

I am unable to reproduce this. There was an issue that was fixed in https://github.com/mdjnelson/moodle-mod_customcert/commit/94cfd4b130392e1a204844a0074c8938d09bf642 but seems you already have that patch,