Milos Djermanovic

Results 696 comments of Milos Djermanovic

Sorry for the delay, I'll review this soon.

I'm fine with adding regular expressions. gitignore patterns are specifically designed for matching relative file paths, while module specifiers can generally be anything (e.g., URL, host-specific protocol...) so for a...

ESLint automatically adds `cwd` and `rulesMeta` when calling the underlying loaded formatter, so there's no need to pass in these properties. In fact, they would be overwritten. https://github.com/eslint/eslint/blob/d1f0831bac173fe3e6e81ff95c5abdbf95b02b65/lib/eslint/eslint.js#L1240-L1256 The `resultsMeta`...

Makes sense to me, marking as accepted.

@nzakas looks like all planned tasks are done so we can close this? * Extract parsing into a class: https://github.com/eslint/eslint/pull/18790 * Extract pre/postprocess into a class: https://github.com/eslint/eslint/pull/18818 * Extract rule...

I also think we should treat this as a breaking change. `fixer.replaceText(node, undefined);` currently works by replacing the node text with `"undefined"`, and although unlikely, such code might be intentional...

> How comprehensive do we want to be in this change? There are a lot of public fixer APIs that take strings I think it should apply to all fixer...

> If the name property and the ignores property are used together, the ignores property will not be applied globally. Since the name property is used to identify the configuration...

@blipk you can ignore directories by specifying `ignores` in a config object that has no other keys (or the only other key is `name`). https://eslint.org/docs/latest/use/configure/ignore

> I think this is something worth considering for compatibility reasons. We do need to complete some [infrastructure work](https://github.com/eslint/eslint/issues/18691) to allow us to backport, though. Makes sense to me. I...