Matthew Booth

Results 389 comments of Matthew Booth

@theboringstuff I just spent some time looking for any reason this might happen, but afaict neither the CAPO code which gets AZs or (my first suspect from your description) gophercloud...

The difference between `TerminalError` and old CAPI Failure conditions is that `TerminalError` is ephemeral. Throwing a `TerminalError` just means that at the top level of the reconciler we won't schedule...

I wonder if this would fit better in cloud-provider-openstack, which IIRC is already adding the other topology labels?

I opened https://github.com/kubernetes/cloud-provider/issues/67 to discuss adding this capability to the cloud provider. We could also do this in CAPO, but we'd have to add a custom label to the machine...

> > > > I opened [kubernetes/cloud-provider#67](https://github.com/kubernetes/cloud-provider/issues/67) to discuss adding this capability to the cloud provider. > > saw this issue, but you mentioned it's `rejected` before, do we have...

> Personally I don't understand why setting cluster name would be enough as it's already part of the LB name. I'm guessing when you've got independent management clusters (e.g. CI/per...

After reading the issue, I agree with @dulek. Lets go back to the use case. I'm not sure I'm following it yet.

Fixed by https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/2008

We'll redesign this when it comes up again. I don't think there's value in keeping this PR around.