cluster-api-provider-openstack
cluster-api-provider-openstack copied to clipboard
switch version from float to int
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1280
Special notes for your reviewer:
- Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [ ] squashed commits
- if necessary:
- [ ] includes documentation
- [ ] adds unit tests
/hold
Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
| Name | Link |
|---|---|
| Latest commit | 161a19f699f480bf8ec6d2ffb10f898aa6e27ab7 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62baa85c752e7e00099320c9 |
| Deploy Preview | https://deploy-preview-1281--kubernetes-sigs-cluster-api-openstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jichenjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jichenjc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm
/lgtm
/cherry-pick release-0.6
@apricote: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.
In response to this:
/cherry-pick release-0.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cherry-pick release-0.6
This looks like a nice cleanup, but as @lentzi90 points out I don't think it's actually fixing the bug. I don't think I would backport it.
@jichenjc This looks like a nice cleanup but I don't think this fixes https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1280. Could you remove that from the issue description to avoid it being closed automatically when we merge this?
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@jichenjc do you want to take this in? It has both approval and lgtm, so just need to remove hold.
/hold cancel
didn't notice this :(
@apricote: new pull request created: #1367
In response to this:
/cherry-pick release-0.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cherry-pick release-0.7
@mdbooth: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-openstack#release-0.7 from head k8s-infra-cherrypick-robot:cherry-pick-1281-to-release-0.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-0.7 and k8s-infra-cherrypick-robot:cherry-pick-1281-to-release-0.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}
In response to this:
/cherry-pick release-0.7
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.