Michael Comella comments

Results 260 comments of


                                            Michael Comella

Add telemetry docs

Document how to add telemetry probe + review process

Document testing best practices

> * Test naming conventions > > * UI vs integration vs unit: when to write which? > > * androidTest package hierarchy > > * robot pattern Landed all...

Document t-shirt sizing, how decides what in milestone, and Story Points add-on

Also that the milestones are prioritized with drag-and-drop.

Document what are android-components and common patterns we see in our applications

Something I wrote up for colors: > Quick rundown on colors: we have [a Photon color palette](https://github.com/FirefoxUX/design-tokens/tree/master/photon-colors) that [we ship with android components](https://github.com/mozilla-mobile/android-components/blob/master/components/ui/colors/src/main/res/values/photon_colors.xml). > >When using colors, we try to...

Document the ways we do code review

Creating review commits or squashing into existing changes?

Consider a place to host shared telemetry documentation

> Alternatively it would be nice if the implementation generated the documentation automatically. In it's simplest form, we could generate the documentation from the javadoc.

Negative duration in "Waiting for socket thread" on fenix

Another thing that is happening is that the request is blocking on the Android UI thread to be free. This is because, for whatever reason, in GeckoView the request needs...

"Upload profile" has hanged and failed to upload several times recently

@julienw I reproduced this maybe 10-15s before Mon Sep 20 09:28:00 PDT 2021. _edit: I clicked try again twice and it failed both times. The second of these try agains...

UsageError message could be more helpful: "Cannot use... auto-generated extension ID"

I submitted a pull request: https://github.com/mozilla/web-ext/pull/3310

[polish] Design UX for dynamic updates to Firebase data

In eng meeting, we discussed receiving partial data from FB to speed up queries (e.g. show Yelp data first, introduce website when we hit factual, add TA data when we...