Matteo Collina comments

Results 3398 comments of


                                            Matteo Collina

Type Enhancement: Allow `FastifyPluginAsync` to return `void` (not only `Promise<void>`)

It's not just a problem with the type. The reason we can support both callbacks and async functions is that we detect that a function will call the callback by...

Type Enhancement: Allow `FastifyPluginAsync` to return `void` (not only `Promise<void>`)

Actually that might not be a bad idea. Would you like to send a PR?

Type Enhancement: Allow `FastifyPluginAsync` to return `void` (not only `Promise<void>`)

shipped in latest avvio.

feat(serializers): avoid implicit sanitization

Can you drop the `future` prefix?

Wouldn't the source code for "Reset Connection Pool in case of destruction" be a problem?

Good question. Is it causing any bugs to you?

interceptors: move `throwOnError` to interceptor

I'm not sure we can, but it would be cool to do

Retrieve the URL when errored

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Increasing Code coverage

> Are there technical constraints preventing us from increasing it? No, but testing CLIs is sometimes painful and cumbersome. > Is there any point in trying to increase it? Absolutely!

Documentation and example of webhook signature check (through rawBody)

Adding `req.body` would create significant performance issues unfortunately.

Add Support for CommonJS

Unfortunately this is not really a long-term solution, as it's a one-time transpilation. I'm not strictly opposed in dual-publishing this, but it needs to have a full solution for doing...