undici icon indicating copy to clipboard operation
undici copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

interceptors: move `throwOnError` to interceptor

Open metcoder95 opened this issue 1 year ago • 2 comments

metcoder95 avatar May 19 '24 10:05 metcoder95

I'm not sure we can, but it would be cool to do

mcollina avatar May 19 '24 10:05 mcollina

Done here: https://github.com/nxtedition/nxt-undici/blob/main/lib/interceptor/response-error.js if someone wants to port it.

ronag avatar May 23 '24 18:05 ronag

Closed by #3331

metcoder95 avatar Jul 14 '24 08:07 metcoder95

We are still not actually using the interceptor

ronag avatar Jul 14 '24 09:07 ronag

True 🤦‍♂️ Too preemptive

metcoder95 avatar Jul 14 '24 09:07 metcoder95

Safe to close now with #3451? 😜

metcoder95 avatar Aug 16 '24 09:08 metcoder95