Matteo Collina

Results 3344 comments of Matteo Collina

@ShogunPanda I think the double revert make the job easier for the releasers.

I have no problem iterating on the feature in the main or just working on a new implementation that does not have these issues on a fresh PR. I'm okay...

I have a feeling that the timeline is rushed, and at least one PR would need to be fast-tracked. The safest bet is to revert, and take a bit of...

> I don't think this is quite accurate. If each hook has access to each thread's workerData or ID, the hook can run code specific to that thread simply by...

> @mcollina would you be okay with allowing nodejs/node#53200 to land if it includes what it has now plus some way for hooks to branch based on thread, like I'm...

Part of the reason we are allocating all those buffers is to avoid creating them at runtime when this information is sent on to the wire. The question is how...

I think we need granular control on how the loaders are passed from parent to children. Moreover, we need to consider the case of a child process/thread changing the hooks...

I'm more thinking something like: ```js new Workers('user.js', { hooks: [] }) ``` or similar.

Thanks for reporting! Would you like to send a Pull Request to address this issue?

Thanks for reporting! Can you provide steps to reproduce? We often need a [reproducible example](https://stackoverflow.com/help/minimal-reproducible-example), e.g. some code that allows someone else to recreate your problem by just copying and...