Matteo Collina

Results 3400 comments of Matteo Collina

I think this is a bit too light on tests, and I'm not sure if this implementation is correct. Can you add some tests where the response is a 304...

@flakey5 this now conflicts

> Shall we consider the exposure of the lenient flags from lhttp as part of this? Yes, I think so.

That's done. --- On a different topic, I think we might want to release v7 _before_ Node.js v23, to be included there.

Do we want to make v7 before v23 is cut? https://github.com/nodejs/Release/issues/1034

Not right now. However, if we miss the deadline for Node.js v23 (seems likely), we will definitely be dropping it, as Node.js v18 goes EOL April 2025.

@trivikr are you arguing we should drop support for Node.js v18 or not? So far it's in and it's not causing many issues.

I've discussed with @ronag in person how we can handle multiple dispatcher versions (even in minor releases). So those are actually not hard requirements.

I plan to ship this on the 27th of November.

As time will pass, it would be harder for us to maintain it. Right now, this means using `tspl` instead of `t.plan()` for our tests, but the list can grown.