MCleinman

Results 11 comments of MCleinman

FYI, I put a PR up for this - https://github.com/ElaWorkshop/TagListView/pull/193

# Request for data collection review form **All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data...

Tagging @travis79 for data-review

> Please add unit tests for all of the new collections or add to the description of this ticket why that is not possible at the moment with a follow...

@brizental ready for another review. Given the non-standard calls in those tests, we're getting some weird data back for the timespans. I've confirmed this looks clean in the debug pings...

@brizental I believe I've addressed all your comments. Testing the number of timespans fails about 10% of the time. When it fails, it's because the test setup has created an...

Working on redoing these tests, but need to close the laptop. Will finish this up tomorrow.

@brizental I believe I've addressed all comments, and this is ready for another round of review.

If it's an oversight, now is the best time to fix it (rather than having partial data for a while). If it's intentional, this seems great. I'd want an affirmative...

@brizental do you have any changes/thoughts, or are we ready to merge this?