mozilla-vpn-client icon indicating copy to clipboard operation
mozilla-vpn-client copied to clipboard

VPN-6116 - Implement missing subscription events

Open brizental opened this issue 1 year ago • 2 comments

I also removed some unused events.

Draft until the data-review is done, but this is ready for eng review already!

brizental avatar Feb 13 '24 10:02 brizental

DATA REVIEW REQUEST

  1. What questions will you answer with this data?
  • How often do started subscription attempts fail?
  • How often do started subscription attempts succeed?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

We need to understand the health of the subscription pipeline.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?

None.

  1. Can current instrumentation answer these questions?

No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
Measurement Name Measurement Description Data Collection Category Tracking Bug
outcome.subscription_already_present The subscription was blocked because the user is already a subscriber. interaction https://mozilla-hub.atlassian.net/browse/VPN-6116
outcome.subscription_failed The subscription process has errored. interaction https://mozilla-hub.atlassian.net/browse/VPN-6116
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented in the Glean Dictionary.

  1. How long will this data be collected?

This collection will be collected permanently. [email protected], [email protected] will be responsible for the permanent collections.

  1. What populations will you measure?

All channels, countries, and locales. No filters.

  1. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

  1. Please provide a general description of how you will analyze this data.

Using Looker dashboards.

  1. Where do you intend to share the results of your analysis?

Withing the Mozilla VPN team and PXI org.

  1. Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection?

No.

brizental avatar Feb 13 '24 10:02 brizental

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Bea and the VPN Team are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

chutten avatar Feb 15 '24 21:02 chutten

@mcleinman Yeah, I should not have moved this out of draft i's totally incomplete. Sorry about that, will move it now and then move it back to "In Review" once it is actually ready.

brizental avatar Mar 14 '24 12:03 brizental

@mcleinman This is now ready for re-review. I see your point about subscriptionCancelled and billingNotAvailable. However neither of these event is listed in the Miro board (https://miro.com/app/board/uXjVM0BZcnc=/[email protected]&openComment=3458764559943493792&mid=8418131&utm_source=notification&utm_medium=email&utm_campaign=mentions&utm_content=reply-to-mention). This might just be an oversight, but even then I'd consider it our of scope for this PR.

brizental avatar May 02 '24 09:05 brizental

If it's an oversight, now is the best time to fix it (rather than having partial data for a while). If it's intentional, this seems great.

I'd want an affirmative confirmation from Santiago that he's okay without those metrics before approving.

mcleinman avatar May 02 '24 17:05 mcleinman

Ticket updated here: https://mozilla-hub.atlassian.net/browse/VPN-6116

albionx avatar May 03 '24 16:05 albionx