Mandar Chitre

Results 139 comments of Mandar Chitre

I've not used the NetCDF format before. From what I see, it seems pretty generic, which also means there are other competitor formats that would warrant consideration. So a few...

The example usage suggests storing the whole environment description in a `.nc` file. I'm wondering if it might be better to store individual fields such as bathymetry, altimetry, etc as...

@harivnkochi I notice you made changes, but didn't request a re-review to indicate that this was ready for review. Is it?

All great points. I started this library because I felt excited by the potential of what Julia could bring to the table for the underwater acoustics world. There's no reason...

Yes, we can get guidelines for contribution in place in August. And even before we do that... contributions are most welcome. It would be good to raise an issue to...

@apatlpo I've gotten a [basic draft of contribution guidelines](https://github.com/org-arl/UnderwaterAcoustics.jl/blob/master/CONTRIBUTING.md) done. Comments/suggestions most welcome.

The code coverage is actually not bad... about 90%, excluding `plot.jl` and `pm_bellhop.jl`: The problem is that plotting routines are hard to meaningfully run CI on. Bellhop requires a working...

Strange. I just ran the copy-pasted code and I get the plot in the correct orientation (as shown in documentation). I tested with latest `Plots v1.19.2` and the `GR` backend....

Your code doesn't run. `ncread()` fails, as there are only 2 methods for that function, none of which match the call signature you have: ``` julia> depth2 = ncread("") ERROR:...