Mohamad Chaarawi

Results 26 comments of Mohamad Chaarawi

@ashleypittman when you land this, please backport to 2.2

> The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it. is there a reason not to backport those tests too?

> > > The dfuse unit tests aren't on 2.2 so this won't be a clean cherry-pick but I'll backport it. > > > > > > is there a...

> We DO want to backport the tests - it's just going to be complicated :) got it. thanks!

seems like this requires to add at least a unit test to verify that it's working properly?

can you please explain how this domain plays into the oclass selection?

> Do you want functional test coverage for the hints and/or dir obj class? i have added DFS tests for the hints. the dir oclass probably need to add some...

> -1 because of the doxygen warning, if this is landed as-is then all builds will fail with that warning until fixed. where is the doxygen warning? the PR is...

refreshed with README update (no code changes)

> -1 because of the doxygen warning, if this is landed as-is then all builds will fail with that warning until fixed. your comments have been addressed, can you please...