daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11375 object: add daos_obj_generate_oid_by_rf2

Open wangshilong opened this issue 2 years ago • 4 comments

Now we have two different fault domains: rank and node. daos_obj_generate_oid_by_rf() use default fault domain which might be wrong. Eg, creating container(with rf_lvl:1)

Introduce another helper daos_obj_generate_oid_by_rf2() which is aware of fault domain.

Required-githooks: true Signed-off-by: Wang Shilong [email protected]

wangshilong avatar Aug 15 '22 11:08 wangshilong

Bug-tracker data: Ticket title is 'fio_small.py failed to create container with -1003' Status is 'In Review' Labels: 'daily_test' https://daosio.atlassian.net/browse/DAOS-11375

github-actions[bot] avatar Aug 15 '22 11:08 github-actions[bot]

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9979/1/execution/node/145/log

daosbuild1 avatar Aug 15 '22 11:08 daosbuild1

can you please explain how this domain plays into the oclass selection?

mchaarawi avatar Aug 15 '22 20:08 mchaarawi

can you please explain how this domain plays into the oclass selection?

See dc_set_oclass() for example number of domains affects group size when object class is unknown, and we have check to compare number of domains and group size, it will return invalid if grp_size > domain_nr.

So it is quite important to get correct number of domains when generating OID.

wangshilong avatar Aug 16 '22 02:08 wangshilong

@daos-stack/daos-gatekeeper pylint and Jira report failure are CI issue and not related to this PR, other tests passed.

wangshilong avatar Aug 22 '22 02:08 wangshilong

@daos-stack/daos-gatekeeper PR modified api minor version which touched Sconcript, there are some other pylint errors triggerd there, but it is not related to this PR

wangshilong avatar Aug 24 '22 07:08 wangshilong

@daos-stack/daos-gatekeeper PR is ready for landing now.

wangshilong avatar Aug 25 '22 01:08 wangshilong