Matěj Cepl
Matěj Cepl
Could we get back to the basics, please? What’s the actual bug this PR is trying to fix?
> My original review still stands: this looks more-or-less like a copy-paste of the Markdown lexer into asciidoc. If asciidoc truly inherits from markdown, then please use proper inheritance. >...
On Wed Apr 9, 2025 at 3:00 PM CEST, orbitalquark wrote: > Please understand that I know nothing about AsciiDoc. I only noticed your PR included rules that looked similar...
OK, let’s kill it here. I don’t have enough motivation to rewrite it from ground, because I don’t care for AsciiDoc enough. If anybody cares, they can do the work.
@bnavigator Ben, what is needed to be done here? I thought that we have removed all `%requires_*` macros in `python-*` packages, didn’t we?
Are we talking about https://github.com/huakim/lua-rpm-macros ? That's 30k uncompressed. Do we really need some architecture for it, or are we in the realms of [astro design](https://www.joelonsoftware.com/2001/04/21/dont-let-architecture-astronauts-scare-you/)? Rewriting `specfile` Python module...
The same problem as #189: a lot of talk without actionable items. Show me the code! And anyway, this is just a duplicate of #189.
https://lists.sr.ht/~martanne/devel/patches/55453 For additional improvements in `lua/lexers/python.lua` you should talk with its upstream, where we pull all lexers from, https://github.com/orbitalquark/scintillua.
This could be probably closed.
> We don't make changes to the standard library tests. We don't backport changes the coredevs don't. Couldn’t you just USE the standard library tests? I don’t know what happens...