Mihai Cara

Results 153 comments of Mihai Cara

@cdeil It looks like C code is used in *a lot* of places. The reason for using this library, I think, is to mitigate the accuracy loss when computing cross...

I am not really picky about this and, if my proposal would slow down this PR - forget about it, but I would suggest that we simply get rid of...

@bsipocz I didn't know you started working on an alternative package. I can't seem to find anything that would suggest this new package can load/parse/write DS9 region files (and, why...

The comment in the second point in https://github.com/astropy/pyregion/blob/master/CHANGES.rst#api-changes is strange: > `ShapeList.as_imagecoord` no longer accepts a `asropy.wcs.WCS` object. **The conversion from pixel to image coordinates depends on the center of...

@keflavich I just clicked on [Getting started](http://astropy-regions.readthedocs.io/en/latest/getting_started.html) which does not mention region files at all. I think this feature one of the main features that I am after in such...

@gbrammer I know. And it is fine for my purpose. I just do not understand the comment in the changelog and I have no idea what "pixel->image conversion" is and...

@gbrammer Is `wcs` an *alternative* to the header or is `header` still required?

It seems that in the past `header` could also be a `WCS` object. In https://github.com/astropy/pyregion/pull/100#issuecomment-301568614 @leejjoon wanted to restore that functionality. Maybe it should be restored as it was instead...

This does look like a bug. It seems to originate from this change: https://github.com/spacetelescope/drizzlepac/commit/9cd039f3834edbbb01b7ac9ba6c7ccbc266ce138#diff-62a80b7810f430706a201f2fce2070fdR680 CC: @stsci-hack

@kyika Thank you for noticing this and reporting it!