Mihai Cara
Mihai Cara
From doctsting: Custom Source Catalogs ---------------------- When ``meta.tweakreg_catalog`` attribute of input data models is `None` or an empty string, then ``tweakreg`` step will attempt to detect sources in the input...
@nden There should be documentation, I think in a file README.rst
I am a big fan of ternary operators... in general. But here I feel that readability suffers a little. Not worth it, IMO. The code is doing what it needs...
It is somewhat difficult to have this as a unit test. Maybe some parts of the model container can be tested as a unit test.
I think it would be useful to get @larrybradley opinion.
My main concern is a constantly growing number of parameters in this _automated pipeline step_. IMO, users would benefit greatly from using stand-alone data analysis packages `photutils` (or `SExtractor` or...
> There are many ways users may want to make specialized catalogs (star finders, segmentation based, PSF fitting, etc.) Just to add to the list, see https://github.com/spacetelescope/jwst/issues/6962
> ... while a catalogue can be passed to tweakreg for the final step aligning everything to an 'absolute' frame, there isn't such functionality to pass either a catalogue function...
Do you plan to make a PR?
> I can! You agree that this is desirable? Or have other thoughts? WRT this, my thoughts are irrelevant. @hbushouse and @stsci-hack thoughts are more important. Especially, I suspect @stsci-hack...