Mihai Cara

Results 196 comments of Mihai Cara

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1445/

Another regression test here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1447/ Previous test was failing because input models' meta could not be updated with info about step being skipped (models were not yet open) and https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1448/

> @mcara About the common function for logging - #8424 refactors tweakreg to reduce memory. If this function prevents or complicate the refactoring, give preference to #8424 and remove it....

> One general question, are these changes required for the check in the title of this PR? No. But... @mairanteodoro is right about similar code being used in too many...

OK. I'll remove logging function and simplify this PR.

Just started https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1449/

@hbushouse @nden regression tests fail with this error: ``` # Check the status of the step is set correctly in the files. result = TweakRegStep.call(rtdata.input) > for fi in result._models:...

https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1450/

I think, @nden, these lines are causing an issue: https://github.com/spacetelescope/jwst/blob/3df35ef10cbfda904a7bfee947d8fd5e87e2092d/jwst/regtest/test_niriss_image.py#L62-L63 And since you already run the step above this call, I do not think this is necessary as the step...

I made a PR that I hope will fix this test: https://github.com/spacetelescope/jwst/pull/8489