Michael Abbott
Michael Abbott
I guess it's your call whether to call it a bugfix :) No rush from me, certainly not worth 2.0. You would have to depend on this package to be...
Do you get a larger disagreement here than this? ```julia julia> dx1 .- dx2 |> extrema (-3.552713678800501e-15, 3.552713678800501e-15) ```
Ah indeed. `unroll=4` did not, but `(1,4)` gives large numbers.
Maybe related, `b` is not like `vec(a)`: ``` julia> count(map(iszero, vec(a))) 7 julia> count(vmap(iszero, vec(a))) 1142 julia> b = rand(Int8,2000); julia> count(vmap(iszero, b)) ERROR: MethodError: no method matching vstore!(::Ptr{Bool}, ::UInt16,...
Such a macro sounds like a neat idea. I wonder if it shouldn't insert the two options as if/else in the body of the function, to avoid strange interactions with...
My suggestion for how to check applicability was going be something ... not so different to yours, but allowing for wrappers such as those of NamedDims, which don't do anything...
I guess the clear criteria are: - false for CuArrays (which we can't see) and sparse arrays - false for reshapes which aren't StridedArrays, and for Diagonal, UpperTriangular etc (these...
I think this is the right approach, meant to dig a bit for edge cases but haven't yet. Re FillArray, if I understand right this is being caught and sent...
OK I tried to make up some test cases. `true --> false` means the change with my attempt below these, instead of the one on master (linked above). It's not...
But not every view of something valid still valid. `StridedArray` has some elaborate checks so that some views of an `Array` are, and some aren't, included. My `elseif M ===...