DoubleFloats.jl icon indicating copy to clipboard operation
DoubleFloats.jl copied to clipboard

Generic `frexp`

Open mcabbott opened this issue 3 years ago • 4 comments

Implements roughly this idea: https://github.com/JuliaMath/DoubleFloats.jl/issues/148#issuecomment-1125418572

mcabbott avatar May 13 '22 00:05 mcabbott

Codecov Report

Merging #150 (950cea6) into master (d4a2e48) will increase coverage by 0.11%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   48.75%   48.87%   +0.11%     
==========================================
  Files          63       63              
  Lines        3425     3429       +4     
==========================================
+ Hits         1670     1676       +6     
+ Misses       1755     1753       -2     
Impacted Files Coverage Δ
src/math/prearith/prearith.jl 58.40% <85.71%> (+3.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4a2e48...950cea6. Read the comment docs.

codecov[bot] avatar May 13 '22 00:05 codecov[bot]

seems reasonable -- it is breaking though. thoughts?

JeffreySarnoff avatar May 13 '22 00:05 JeffreySarnoff

I guess it's your call whether to call it a bugfix :)

No rush from me, certainly not worth 2.0.

You would have to depend on this package to be relying on the old behaviour. None of the direct packages in General seem to. What people do in private I don't know.


From Juliahub, list of deps: https://juliahub.com/ui/Packages/DoubleFloats/KzTCm/1.2.2?page=2 Searching the direct ones, none contain frexp

Packages which do use or define frexp include:

https://github.com/JuliaArbTypes/ArbFloats.jl/blob/9710fb9b65adff5a62336b6eff50b4d55f378f75/src/basics/IEEEfp.jl#L22-L27

https://github.com/StevenWhitaker/BlochSim.jl/blob/f5a353867c2b08c2e40b6737e97586dad8882581/src/expm.jl#L200-L212 Defines it for Dual numbers

https://github.com/JuliaPhysics/Measurements.jl/blob/b26fbff340f6a9c1432a06c8941ff9ba9a0ca34f/src/math.jl#L580-L583 Defines it to pass measurements along

https://github.com/JuliaMath/Quadmath.jl/blob/154de7bd735946b4e8dba03426c7e3e81bc3fbd1/src/Quadmath.jl#L388-L392

https://github.com/PainterQubits/Unitful.jl/blob/960e09ef518b0d3ff54747460b9c3872c08df0d7/src/quantities.jl#L467-L470 Defines it to pass units along

mcabbott avatar May 13 '22 01:05 mcabbott