Michael Abbott
Michael Abbott
There are cases where the view is faster, and many packages have written such a thing. In https://github.com/JuliaLang/julia/issues/21672 there was not much enthusiasm for adding a new stacked array type...
I meant to come back to check what array types are returned, I have forgotten what the logic was here. I hadn't tried StructArrays but agree it's nice if they...
I hope it's nearly ready. Remaining questions are, I think: * What should happen in empty cases? [Examples here](https://github.com/JuliaLang/julia/pull/43334#discussion_r771982616) and concerns about this introducing type-instabilities [here](https://github.com/JuliaLang/julia/pull/43334#issuecomment-1183714064). Maybe it should produce...
One overload question is what happens to immutable arrays, e.g. `stack(SA[i,2i] for i in SA[1,2,3])` currently makes an MMatrix, could prefer an SMatrix. And what should a stack of ImmutableArrays...
Ok [72a9de9](https://github.com/JuliaLang/julia/pull/43334/commits/72a9de936cddc3e9fa5e18ea100f58c4b59fc1ac) makes all empty cases give errors. This restores type-stability in the StructArray & JLArray examples above.
[4169526](https://github.com/JuliaLang/julia/pull/43334/commits/41695263aa9c1ee2a811dafe5abddf9843896826) adds a NEWS entry. Maybe this is ready?
Should I read anything into the test failures? They appear the same on re-running, and don't seem to appear on other recent PRs. But they also look unrelated to me,...
See also https://github.com/JuliaLang/julia/pull/45221 which mentions that there is this default for `Int` (although not at present for `UInt`)
If this is approved, can you clarify what you envisage happening with the earlier https://github.com/JuliaLang/julia/pull/45221? That also aims to explain the Int default, but does not make a separate `Int`...
I thought the example was showing that `Int` and `Int64` would access two different docstrings. That seems a little confusing to me, what details should appear in one and not...