mbongaerts
mbongaerts
So, I recently implemented the R-graph method for pyOD. R-graph also does not have trainable parameters. So each time you want to evaluate a test set you need to 'refit'...
Similar to my comment in https://github.com/yzhao062/pyod/issues/395 I would suggest to change the docsstring: https://github.com/yzhao062/pyod/blob/5f5064ef9145130a31ce5510cee44dee520cb119/pyod/models/ecod.py#L128 where 'fitted detector' should be removed, since this could mislead the user by thinking learning parameters...
> John-Almardeny, thank you for you response. I will dive more into this algorithm to understand how it works. It only feels counter-intuitive since most algorithms use settings that only...
I think I see the 'problem' with this implementation, and the implementation is a bit weird to me. During fitting the model the `self.decision_function(X)` is called, where lets say `X`...
Thank you for your response John-Almardeny, and thanks for the clarification. I think it is important for users to understand this behavior (such as me), since the scikit-learn styling in...
@houssamzenati, I made an implementation of the ALAD method for pyOD. It would be great if you could review it. Thanks!
> sorry there will be some delay on my end to multiple ddl...will review very soon!! thanks No problem! Thanks!
Similar to my comment in https://github.com/yzhao062/pyod/issues/395 I would suggest to change the docsstring: https://github.com/yzhao062/pyod/blob/7aeefcf65ceb0196434b7adb4fd706bfb404e4e2/pyod/models/copod.py#L126 where 'fitted detector' should be removed, since this could mislead the user by thinking learning parameters...
Dear @John-Almardeny, The AnoGAN implementation is automatically tested on multiple platforms when doing a pull request. You can see the results here: [appveyor]( https://ci.appveyor.com/project/yzhao062/pyod/builds/44782185) So, I guess there is something...
Dear @John-Almardeny, Did you try to run my example above? Your point 2 is weird indeed. My initial Pull request did contain all of this actually: https://github.com/yzhao062/pyod/pull/412/files#diff-2b5c140da123fa09f91ac1d6cf657fc6da9fabfb5f85aee6b72ce8f9fac3623a Maybe @yzhao062 knows...