pyod
pyod copied to clipboard
ALAD method implemented
Implemented the ALAD method
paper: https://arxiv.org/pdf/1812.02288.pdf
All Submissions Basics:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you checked all Issues to tie the PR to a specific one?
All Submissions Cores:
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [x] Have you written new tests for your core changes, as applicable?
- [x] Have you successfully ran tests with your changes locally?
- [x] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
- [ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.
New Model Submissions:
- [x] Have you created a <NewModel>.py in ~/pyod/models/?
- [x] Have you created a <NewModel>_example.py in ~/examples/?
- [x] Have you created a test_<NewModel>.py in ~/pyod/test/?
- [x] Have you lint your code locally prior to submission?
@houssamzenati, I made an implementation of the ALAD method for pyOD. It would be great if you could review it. Thanks!
Pull Request Test Coverage Report for Build 2730406361
- 276 of 329 (83.89%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.5%) to 95.435%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
pyod/test/test_alad.py | 79 | 80 | 98.75% |
pyod/models/alad.py | 197 | 249 | 79.12% |
<!-- | Total: | 276 | 329 |
Totals | |
---|---|
Change from base Build 2618158103: | -0.5% |
Covered Lines: | 7882 |
Relevant Lines: | 8259 |
💛 - Coveralls
sorry there will be some delay on my end to multiple ddl...will review very soon!! thanks
sorry there will be some delay on my end to multiple ddl...will review very soon!! thanks
No problem! Thanks!