Results 133 comments of Mike Bland

@FrankPortman This generally looks OK to me, but in addition to converting the manual tests to test scripts, please look into the test failures from CI and fix those. They...

@tim-yobi Yes, examples, a fix, and/or documentation would be helpful.

Quick comments: - Please use the typical __Description__ and __Motivation__ pull request template, even for these smaller PRs. - [This appears to have broken 'test_twitter_scrooge_example' from 'test/shell/test_examples.sh'](https://buildkite.com/bazel/rules-scala-scala/builds/5844#019a2b70-5e4a-4a7e-9573-b486a17345b9/121-175). Does `test/shell/test_examples.sh` (as...

Please add a test for this specific case, and I'd be happy to merge it.

I asked around internally and got the green light all around. Count me in. As always, I'll need a bit of help, but I'll do what I can to help...

@simuons I see that #1766 landed, but do you also need to update the repo configuration via the GitHub UI to add @WojciechMazur and me as admins?

@simuons Thanks! I seem to have GitHub admin access now. But it seems my access to Buildkite is limited. For example, I seem to lack permissions cancel the current [build...

I haven't tried this, but [ScalaPB > SBT Settings > Additional options to the generator](https://scalapb.github.io/docs/sbt-settings/#additional-options-to-the-generator) mentions the `scala3_sources` option: > If set, generates sources that are error-free under `-source future`...

@meteorcloudy Note that the bulk of the diff in that pull request is the zlib-1.3.1 upgrade. The rest of the changes are exactly from the patch from #27026 (which I...

@meteorcloudy I've been poking at this the past week and a half. Between cherrypicking fixes from `master` and applying my own test fixes, all the Linux builds are now passing....