Mike Bland
Mike Bland
I've confirmed [in my replace-custom-scalapb-wrappers-with-protoc-bridge-0.9.8 branch](https://github.com/mbland/rules_scala/pull/new/replace-custom-scalapb-wrappers-with-protoc-bridge-0.9.8) that the recently released [protoc-bridge 0.9.8](https://github.com/scalapb/protoc-bridge/releases/tag/v0.9.8) resolves scalapb/ScalaPB#1771 (i.e., `protoc-bridge` catches `scalapb.ScalaPbCodeGenerator` errors, so we don't have to). I've since closed that issue, and...
Here are some detailed findings from [my `replace-custom-scalapb-wrappers-with-protoc-bridge-0.9.8` branch](https://github.com/mbland/rules_scala/pull/new/replace-custom-scalapb-wrappers-with-protoc-bridge-0.9.8), specifically https://github.com/mbland/rules_scala/commit/2d7b891abf35ef0fb18aac4fc21bb617fef7672b, regarding our handling of ScalaPB's [`compilerplugin`](https://github.com/scalapb/ScalaPB/tree/v0.11.17/compiler-plugin/src), [`protoc-gen`](https://github.com/scalapb/protoc-bridge/tree/v0.9.8/protoc-gen/src), and [`protoc-bridge`](https://github.com/scalapb/protoc-bridge/tree/v0.9.8/bridge/src) artifacts. Please see that commit message for even more details....
@kczulko The key line in the output: ```txt Caused by: com.google.protobuf.RuntimeVersion$ProtobufRuntimeVersionException: Detected incompatible Protobuf Gencode/Runtime versions when loading com.google.devtools.build.lib.worker.WorkerProtocol$WorkRequest: gencode 4.28.3, runtime 4.28.2. Runtime version cannot be older than the...
Whoops, I was looking at the `protoc-{bridge,gen}` version 0.9.8. ScalaPB 1.0.0-alpha.1 looks correct there. ~~Also, see the table in the original issue message: neither version 0.9.8 nor 0.11.17 of ScalaPB...
Ah, the updated error message containing `LazyStringArrayList` looks like the one from #1637, referenced as part of the original analysis here. What version of `protobuf` and `protobuf-java` are you using?...
FYI, I filed protocolbuffers/protobuf#22225 for the `rules_jvm_external` part. It's approved, but it'll have to get merged, and then there'll need to be a `protobuf` release. And at any rate, we'll...
@simuons @liucijus As always, I'm happy to split this into separate pull requests, or at least separate commits, if you'd prefer. Either way, the recommended breakdown would be to review...
@simuons Thanks, done. Once this lands, I'll create another PR for a version bump. Also, the [last_green build is failing again](https://buildkite.com/bazel/rules-scala-scala/builds/5700#01983735-237c-4577-b51b-3232ce6082be): ```txt INFO: Repo +scala_deps+scala_proto_rules_scalapb_protoc_gen_2_12_20 defined by rule _jvm_import_external in...
@simuons Please feel free to assign this to me. This line is the source of the warning: https://github.com/bazel-contrib/rules_scala/blob/v7.0.0/scala/private/macros/scala_repositories.bzl#L90 It'll take a little work to come up with a way to...
My [fix-1743-scala-compiler-source-warning](https://github.com/mbland/rules_scala/tree/fix-1743-scala-compiler-source-warning) branch solves this now. I confirmed this by hand by running `bazel clean; bazel build //src/...` before and after applying the commits on that branch and noticing the...