rules_scala icon indicating copy to clipboard operation
rules_scala copied to clipboard

Use rules_jvm_external for internal dependencies

Open jadenPete opened this issue 3 months ago • 3 comments

Description

This PR is the second in a series to refactor the ruleset to use rules_jvm_external for fetching all Maven artifacts.

It deletes scala/private/extensions/dev_deps.bzl and refactors the ruleset to pull all internal dependencies (previously declared in that module) using rules_jvm_external. It also makes rules_jvm_external a required dependency of the ruleset.

Motivation

Please see this PR for more information on this initiative and the motivations behind it: https://github.com/bazel-contrib/rules_scala/pull/1775

jadenPete avatar Oct 28 '25 15:10 jadenPete

Quick comments:

I think I'm beginning to see some of the benefit of using rules_jvm_external here. I have a few comments to make, but I'll return to this after the buildifier-prebuilt change lands and this pull request fixes the test_twitter_scrooge_example breakage.

Note that if/when #1785 lands, which should happen first (if we decide to merge it), both the buildifier-prebuilt change and this PR will require rebasing and making MODULE.bazel.lock updates.

mbland avatar Oct 28 '25 15:10 mbland

Thank you for the comments! My bad, I've updated the description to follow that format.

Working on splitting out the buildifier-prebuilt changes and fixing the failing test now.

jadenPete avatar Oct 29 '25 15:10 jadenPete

Ok, I've opened a separate PR for the buildifier_prebuilt changes! https://github.com/bazel-contrib/rules_scala/pull/1788

Also, the tests should pass now. That PR needs to be merged before this one, so consider this PR to be stacked on that one and please ignore the first commit when reviewing it.

jadenPete avatar Nov 03 '25 18:11 jadenPete